-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/net/nettest: TestTestConn runs out of memory on Plan 9 #20489
Comments
The issue happens in testConcurrentMethods. It doesn't always fail, but it gets much better with a lower value of n. |
This might be related to an issue in the implementation of deadlines on Plan 9. However, this is a bit difficult to debug from the very bad Internet connection here. I propose we temporarily skip the test, so I can investigate it later, once I'll be back home. |
CL https://golang.org/cl/44130 mentions this issue. |
Skipping on plan9 is fine for now. Be sure to reference the relevant bug(s) in the commit that disables it. |
This test is running out of memory on Plan 9. Updates golang/go#20489. Change-Id: I79cdea9c31f396b6ef5c47474674ad736362b232 Reviewed-on: https://go-review.googlesource.com/44130 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
A part of me feels bad for breaking Plan 9, but another part of is intrigued that the nettest may have unearthed an issue :P |
Is it possible this was fixed by https://go.dev/cl/470215 (CC @millerresearch)? If so, someone could try re-enabling the test and running it some large number of times to check for remaining failures. |
(I was going to mark this issue |
CL 37404 added TestTestConn, which is running out of memory on Plan 9.
See https://build.golang.org/log/91d479d449f2d4e18ff585e87fcf0867a4fd2ea7
The text was updated successfully, but these errors were encountered: