Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: spurious error in TestPanicRace #20594

Closed
randall77 opened this issue Jun 6, 2017 · 1 comment

Comments

Projects
None yet
4 participants
@randall77
Copy link
Contributor

commented Jun 6, 2017

Saw on the trybots for CL 45018:

--- FAIL: TestPanicRace (0.00s)
crash_test.go:584: program exited successfully, should have failed
crash_test.go:587:
crash_test.go:596: did not find expected string "panic: crash"
crash_test.go:596: did not find expected string "PanicRace"
crash_test.go:596: did not find expected string "created by "

I don't think this has anything to do with my CL, it only does additional compile-time checks, and those checks are not enabled on this builder. Flaky test?

https://storage.googleapis.com/go-build-log/6c7e4f31/linux-amd64_b2988fea.log

@randall77 randall77 added the Testing label Jun 6, 2017

@randall77 randall77 added this to the Go1.9 milestone Jun 6, 2017

@bradfitz bradfitz added the help wanted label Jun 7, 2017

@gopherbot

This comment has been minimized.

Copy link

commented Jun 7, 2017

CL https://golang.org/cl/45020 mentions this issue.

@gopherbot gopherbot closed this in b5a0f71 Jun 7, 2017

@golang golang locked and limited conversation to collaborators Jun 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.