Skip to content

cmd/compile: error positions are verbose in cgo-using files #20628

Closed

Description

@aclements

What version of Go are you using (go version)?

go version devel +11c61eb6af Fri Jun 9 04:38:37 2017 +0000 linux/amd64

What did you do?

Build a file that imports "C" and has compile errors in it.

What did you expect to see?

Go 1.8 printed out succinct error messages that were the same whether or not the package imported "C". Eg.,

$ go build
./model.go:89: invalid operation: i < n (mismatched types int and C.uint)

What did you see instead?

At tip, the error positions are much more verbose and include a reference to a temporary path generated by the cgo tool that doesn't even exist after the go tool exits:

$ go build
./model.go:89[/tmp/go-build298567481/github.com/aclements/go-z3/z3/_test/_obj_test/model.cgo1.go:110:25]: invalid operation: i < n (mismatched types int and _Ctype_uint)

/cc @griesemer @mdempsky

Activity

  1. ALTree commented on Jun 9, 2017

    @ALTree
    Member

    Introduced in 2a5cf48.

  2. odeke-em commented on Jun 12, 2017

    @odeke-em
    Member

    Repro for a test when fixing it:

    package main
    
    import "C"
    
    func main() {
    	n := C.uint(10)
    	i := 1
    	if i < n {
    	}
    }
  3. griesemer commented on Jun 12, 2017

    @griesemer
    Contributor

    This may be due to a regex not matching anymore when the position information contains column info. It may be as easy as disabling the printing of column info when invoking the compiler.

  4. self-assigned this
    on Jun 12, 2017
  5. added this to the Go1.9 milestone on Jun 12, 2017
  6. gopherbot commented on Jun 13, 2017

    @gopherbot
    Contributor

    CL https://golang.org/cl/45612 mentions this issue.

  7. locked and limited conversation to collaborators on Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions