Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build: make gopherbot leave review comments on Gerrit for common mistakes #20648
A common mistake when adding a new Go source file to the Go project is to omit the license header.
This means that a human has to point out the mistake every time, and for each file.
I think it makes sense to have the trybots do this instead. It'll save a bit of time and effort for reviewers, and help catch an easy mistake earlier in the review process for the author of the CL.
@ianlancetaylor, once we accept Github PRs, it's no longer a good assumption that all users use
@andybons, this bug is about doing a Tricorder-style thing for Go, where gopherbot looks at pending CLs and runs plugins and drops review comments in Gerrit.
Start of work for it is in pending CL https://go-review.googlesource.com/c/build/+/38285