Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: "go", "type" excluded as import paths - still needed? #20708

Closed
griesemer opened this issue Jun 16, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@griesemer
Copy link
Contributor

commented Jun 16, 2017

Reminder issue. Investigate/document rationale for exclusion (see subr.go, func isbadimport). If implementation restriction, document in spec.

@griesemer griesemer added this to the Go1.10 milestone Jun 16, 2017

@griesemer griesemer self-assigned this Jun 16, 2017

@griesemer griesemer modified the milestones: Go1.10, Go1.11 Nov 28, 2017

@gopherbot

This comment has been minimized.

Copy link

commented Jan 12, 2018

Change https://golang.org/cl/87496 mentions this issue: cmd/compile: document reserved import paths

@gopherbot gopherbot closed this in 8554fd6 Jan 12, 2018

@odeke-em

This comment has been minimized.

Copy link
Member

commented Jan 13, 2018

@griesemer you documented the reserved import paths in cmd/compile, however initially you mentioned that we should document this in the spec as per

If implementation restriction, document in spec.

Should we reopen this issue and document this in the spec or am I interpreting the usage of the word "spec" literally, yet you meant document it in cmd/compile/internal/gc/subr.go?

@griesemer

This comment has been minimized.

Copy link
Contributor Author

commented Jan 13, 2018

No. This is just an implementation detail because the compiler happens to use these link symbols. It could use anything else but doesn't at the moment.

@odeke-em

This comment has been minimized.

Copy link
Member

commented Jan 13, 2018

Gotcha gotcha, thanks.

@golang golang locked and limited conversation to collaborators Jan 13, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.