Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TimeoutHandler doesn't set a timeout on Request.Context #20712

Closed
jmhodges opened this issue Jun 17, 2017 · 2 comments
Closed

net/http: TimeoutHandler doesn't set a timeout on Request.Context #20712

jmhodges opened this issue Jun 17, 2017 · 2 comments

Comments

@jmhodges
Copy link
Contributor

@jmhodges jmhodges commented Jun 17, 2017

On Go version 1.8.3, net/http.TimeoutHandler doesn't apply context.WithTimeout to the passed in http.Request's context. It's desirable now that context is everywhere in the stdlib. It seems like it might also simplify the timeoutHandler.ServeHTTP implementation.

This also seems to be the case in 1.9beta1.

@odeke-em

This comment has been minimized.

Copy link
Member

@odeke-em odeke-em commented Jun 20, 2017

/cc @bradfitz

@bradfitz bradfitz added this to the Go1.10 milestone Jun 21, 2017
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jun 22, 2017

CL https://golang.org/cl/46412 mentions this issue.

@gopherbot gopherbot closed this in 9e7b30b Aug 28, 2017
@golang golang locked and limited conversation to collaborators Aug 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.