Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/gomvpkg: mishandles main package #20715

Open
dvyukov opened this issue Jun 17, 2017 · 2 comments
Open

x/tools/cmd/gomvpkg: mishandles main package #20715

dvyukov opened this issue Jun 17, 2017 · 2 comments
Labels
Milestone

Comments

@dvyukov
Copy link
Member

@dvyukov dvyukov commented Jun 17, 2017

gomvpkg -from foo/bar -to baz/bar where foo/bar is package main renames package to bar, which makes it non-executable. May look silly, but the main intention was to take advantage of -vcs_mv_cmd "git mv {{.Src}} {{.Dst}}" part. gomvpkg should not rename main package.

@gopherbot gopherbot added this to the Unreleased milestone Jun 17, 2017
@dvyukov

This comment has been minimized.

Copy link
Member Author

@dvyukov dvyukov commented Jun 17, 2017

@alandonovan

This comment has been minimized.

Copy link
Contributor

@alandonovan alandonovan commented Aug 2, 2017

@gopherbot gopherbot added the Tools label Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.