Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscall: RawSyscall should panic on solaris #20833

Closed
binarycrusader opened this issue Jun 28, 2017 · 2 comments
Closed

syscall: RawSyscall should panic on solaris #20833

binarycrusader opened this issue Jun 28, 2017 · 2 comments

Comments

@binarycrusader
Copy link
Contributor

@binarycrusader binarycrusader commented Jun 28, 2017

As noted in #20832, RawSyscall should panic on solaris as raw system calls are never actually possible on Solaris.

From syscall_solaris.go:

// This is syscall.RawSyscall, it exists to satisfy some build dependency,
// but it doesn't work correctly.
//
// DO NOT USE!
//
// TODO(aram): make this panic once we stop calling fcntl(2) in net using it.
func syscall_rawsyscall(trap, a1, a2, a3 uintptr) (r1, r2, err uintptr) {

From syscall/exec_solaris.go:

// We call hand-crafted syscalls, implemented in
// ../runtime/syscall_solaris.go, rather than generated libc wrappers
// because we need to avoid lazy-loading the functions (might malloc,
// split the stack, or acquire mutexes). We can't call RawSyscall
// because it's not safe even for BSD-subsystem calls.

Any existing use of RawSyscall should be excised first, and then it should be changed to panic on Solaris.

This is definitely for 1.10+

@bradfitz bradfitz added this to the Go1.10 milestone Jun 28, 2017
@davecb
Copy link

@davecb davecb commented Jun 29, 2017

I'm an old Solarii from the ABI team who "owned" the standard libraries, if I can help with this, loop me in.

@gopherbot
Copy link

@gopherbot gopherbot commented Dec 7, 2017

Change https://golang.org/cl/82636 mentions this issue: runtime: make RawSyscall panic on Solaris

@gopherbot gopherbot closed this in 613f8ca Dec 8, 2017
@golang golang locked and limited conversation to collaborators Dec 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.