Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: Document change in cookie sanitization in the release notes? #20834

Closed
lucas-clemente opened this issue Jun 28, 2017 · 2 comments
Closed

Comments

@lucas-clemente
Copy link
Contributor

@lucas-clemente lucas-clemente commented Jun 28, 2017

This change to sanitizeCookieValue (to fix #18627) broke the quic-go unit tests going from 1.8 to 1.9b2. I don't know about the policy for mentioning bugfixes there, but maybe this should be mentioned in the release notes for net/http? I'd be happy to write a CL if you feel like it's worth it.

@lucas-clemente lucas-clemente changed the title http: Document change in cookie sanitization in the release notes? net/http: Document change in cookie sanitization in the release notes? Jun 28, 2017
@bradfitz bradfitz added this to the Go1.9Maybe milestone Jun 28, 2017
@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Jun 28, 2017

Feel free to send a doc change. Thanks.

Be sure to add the like elsewhere in the file.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jun 29, 2017

CL https://golang.org/cl/47151 mentions this issue.

@gopherbot gopherbot closed this in ee45504 Jun 30, 2017
@golang golang locked and limited conversation to collaborators Jun 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.