x/build/maintner/maintnerd: accumulating defunct git processes

[bradfitz]

Just noticed that maintnerd is accumulated defunct git processes:

$ kubectl exec maintner-deployment-705276126-18d3b ps
  PID TTY          TIME CMD
    1 ?        03:17:37 maintnerd
 1015 ?        00:00:00 git <defunct>
 3527 ?        00:00:00 git <defunct>
15040 ?        00:00:00 git <defunct>
26522 ?        00:00:00 ps

Why? Investigate.

Related: #18881

/cc @andybons

[bradfitz]

This is no longer an issue. We run on tini now:

bradfitz@go:~/src/golang.org/x/build$ k exec -ti maintnerd-deployment-7ddfd868d4-wkf7c /bin/bash
root@maintnerd-deployment-7ddfd868d4-wkf7c:/# ps ax
    PID TTY      STAT   TIME COMMAND
      1 ?        Ss     0:41 /tini -- /maintnerd --config=go --bucket=golang-maintner-log --verbose --data-dir=/cache --listen=:80 --autocert=maintner.golang.org --autocert-bucket=golan
      8 ?        Sl   774:52 /maintnerd --config=go --bucket=golang-maintner-log --verbose --data-dir=/cache --listen=:80 --autocert=maintner.golang.org --autocert-bucket=golang-maintne
1472495 ?        Ss     0:00 /bin/bash
1472502 ?        R+     0:00 ps ax

I guess that happened in golang/build@3e2c190 for #23705

I love that this bug was ignored and then it bit us later when it got worse, and then we fixed the later bug number and forgot about this one. Sigh.

/cc @dmitshur to amuse him too.