New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: why must Chmod mode be non-zero on Windows? #20858

Open
bradfitz opened this Issue Jun 30, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@bradfitz
Member

bradfitz commented Jun 30, 2017

From the beginning of Go until at least Go 1.9, the os.Chmod mode parameter must be non-zero on Windows.

I don't see why, though. syscall.Chmod returns EINVAL otherwise. Can we remove that?

I documented this in CL 47254 at least.

/cc @alexbrainman @ianlancetaylor

@bradfitz bradfitz added this to the Go1.10 milestone Jun 30, 2017

@gopherbot

This comment has been minimized.

gopherbot commented Jun 30, 2017

CL https://golang.org/cl/47254 mentions this issue.

gopherbot pushed a commit that referenced this issue Jun 30, 2017

os: add documentation for Windows users
Updates #18581
Updates #20858

Change-Id: I6b5ce0e255a42c028d46815fff5a5aca68690fd9
Reviewed-on: https://go-review.googlesource.com/47254
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@bradfitz

This comment has been minimized.

Member

bradfitz commented Nov 30, 2017

@rsc, the @golang/proposal-review NeedsDecision queries aren't working if old things like this are still open.

Bumping to Go 1.11.

@bradfitz bradfitz modified the milestones: Go1.10, Go1.11 Nov 30, 2017

@ianlancetaylor ianlancetaylor modified the milestones: Go1.11, Go1.12 Jun 27, 2018

@rsc

This comment has been minimized.

Contributor

rsc commented Nov 14, 2018

Let's try changing this at the start of Go 1.13 and see what breaks. I can't explain it.

@rsc rsc modified the milestones: Go1.12, Go1.13 Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment