Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/present: add footer template #20946

Open
dancingeek opened this issue Jul 7, 2017 · 9 comments

Comments

Projects
None yet
10 participants
@dancingeek
Copy link

commented Jul 7, 2017

The Go Present tool lacks the ability to add a "footer" to each slide page. Having such functionality is required at some companies for internal presentations, e.g. for marking the slide deck as confidential. Such a template could also be used to expose other metadata about the specific slide such as the slide number.

I would like to implement a change to the slide format specification that enables the definition of a footer element.

It might also be useful to add the ability to turn off the footer for a specific slide.

I will update this proposal with specific proposed specification changes if this functionality is generally agreeable.

Update - Proposal

I propose being able to optionally add to the Author block of the title slide:

<footer | [#]>

The author section may also contain a footer element. The foot can be broken into three segments with justifications using the pipe (|) character. The justifications are left, center, and right. Use [#] to denote the slide number.

Examples:

<Go rules! | | [#]>

Go rules!                                                                    1

<|Go rules! | [#]>

                                Go rules!                                    1

<[#]>

1

<|[#]>

                                       1

I was unable to come up with a clean way to have some form of nofooter directive. I don't have strong feelings toward the chosen delimiters, they are merely what made sense to me.

@gopherbot gopherbot added this to the Proposal milestone Jul 7, 2017

@gopherbot gopherbot added the Proposal label Jul 7, 2017

@rsc

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2017

OK.

@rsc rsc changed the title proposal: x/tools/present Add footer template proposal: x/tools/present: add footer template Jul 17, 2017

@spf13

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2017

The present tool needs some love. The fonts are too small. The template and css aren't modifiable. The entire thing doesn't work in mobile properly.

I think we should include this feature as part of a larger refactoring.

cc @andybons

@andybons andybons self-assigned this Jul 17, 2017

@dancingeek

This comment has been minimized.

Copy link
Author

commented Jul 18, 2017

I have updated the description to include the proposal.

@lucor

This comment has been minimized.

Copy link

commented Apr 16, 2018

I did an implementation that I'd be happy to donate if useful: lucor/tools@c0a3c29

@agnivade

This comment has been minimized.

Copy link
Member

commented Apr 17, 2018

Feel free to send a PR.

@gopherbot

This comment has been minimized.

Copy link

commented Apr 17, 2018

Change https://golang.org/cl/107515 mentions this issue: present: add footer template

@justinfx

This comment has been minimized.

Copy link

commented Jun 18, 2018

I figured I would add this comment to this particular issue since it seems relevant, but has anyone considered lifting and cleaning up the functionality from https://github.com/davelaursen/present-plus into the present tool? I am currently using present-plus, which seems to be abandoned. But it is extremely useful. I was able to completely replicate my own companys marketing demo template as a theme, including the custom footer with our logo. I was able to do all kinds of things like improve the sizing of the code view and various margins and sizes.

Having the ability to define optional present templates be part of the official tool would be amazing.

@ALTree ALTree removed the Proposal label Sep 22, 2018

@gopherbot gopherbot added the Proposal label Sep 22, 2018

@anjmao

This comment has been minimized.

Copy link

commented Jan 14, 2019

@agnivade Hi, could you tell the status of this proposal? I wonder why it was not reviewed for such a long time? I expect to get feedback faster than after a year. Sorry if I misunderstood something.

@andybons andybons changed the title proposal: x/tools/present: add footer template x/tools/present: add footer template Jan 14, 2019

@andybons andybons added the NeedsFix label Jan 14, 2019

@andybons andybons modified the milestones: Proposal, Unreleased Jan 14, 2019

@andybons

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

@anjmao the proposal was accepted in July.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.