Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: avoid copying all values in nilcheckelim2 #20964

Closed
josharian opened this issue Jul 10, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@josharian
Copy link
Contributor

commented Jul 10, 2017

nilcheckelim2 cleans up by copying b.Values in a loop, omitting OpUnknowns. However, the common case is that there are no OpUnknowns, in which case we can skip a lot of work. This is a reminder issue to track whether there are any OpUnknowns and if so, skip the copying entirely.

@josharian josharian added the ToolSpeed label Jul 10, 2017

@josharian josharian added this to the Go1.10 milestone Jul 10, 2017

@josharian josharian self-assigned this Jul 10, 2017

@gopherbot

This comment has been minimized.

Copy link

commented Sep 22, 2017

Change https://golang.org/cl/65590 mentions this issue: cmd/compile: avoid copying in nilcheckelim2

@gopherbot

This comment has been minimized.

Copy link

commented Sep 23, 2017

Change https://golang.org/cl/65651 mentions this issue: cmd/compile: avoid copying in nilcheckelim2

@gopherbot gopherbot closed this in bad5abf Sep 29, 2017

@golang golang locked and limited conversation to collaborators Sep 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.