Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: use SBFX / UBFX instructions for bit extraction on ARMv7 #20966

Closed
benshi001 opened this issue Jul 10, 2017 · 3 comments
Closed

cmd/compile: use SBFX / UBFX instructions for bit extraction on ARMv7 #20966

benshi001 opened this issue Jul 10, 2017 · 3 comments
Assignees
Milestone

Comments

@benshi001
Copy link
Member

@benshi001 benshi001 commented Jul 10, 2017

(SLLconst (SRAconst x [d]) [c]) -> SBFX
(SRAconst (SLLconst x [d]) [c]) -> SBFX
(SLLconst (SRLconst x [d]) [c]) -> UBFX
(SRLconst (SLLconst x [d]) [c]) -> UBFX

SBFX and UBFX are available on ARMv7.

@ALTree ALTree added this to the Go1.10 milestone Jul 10, 2017
@benshi001

This comment has been minimized.

Copy link
Member Author

@benshi001 benshi001 commented Jul 12, 2017

Please also assign it to me. ^_^

@ALTree

This comment has been minimized.

Copy link
Member

@ALTree ALTree commented Jul 12, 2017

@benshi001 Can you change the title to "cmd/compile: use SBFX / UBFX instructions for XXX on ARMv7" (where XXX is the operation you're optimizing, I think it's "bit extraction"(?)).

@benshi001 benshi001 changed the title cmd/compile: optimizate with SBFX / UBFX cmd/compile: use SBFX / UBFX instructions for bit extraction on ARMv7 Jul 12, 2017
@ALTree ALTree added the Performance label Jul 12, 2017
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Sep 20, 2017

Change https://golang.org/cl/64950 mentions this issue: cmd/compile: optimized ARM code with BFX/BFXU

@gopherbot gopherbot closed this in 9732485 Sep 21, 2017
@golang golang locked and limited conversation to collaborators Sep 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.