Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
time: misleading "zoneinfo.zip: no such file or directory" error when trying to load non-existent timezone #20969
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
Not a regression from Go 1.8 (or any other prior release), so targeting Go 1.10 for consideration.
I don't think it's a good idea to get rid of the part of the error message that says where it was looking to find the answer (which zip file path). You want it to say both things? Failed to find New_Yaark and also the zip file path?
can somebody answer:
(i hope that question did not come across snarky or sarcastic. I just need clarity on that before I can think of suggestions for improvement)
@Dieterbe, oh, I see what you're suggesting now. That if, say,
That's a possibility. I don't believe the intent of the current code is to blend two sources of information (zoneinfo dir and zip), but just to try the zip if the file on disk doesn't exist. IIRC, currently the code just tries to open a single file under
referenced this issue
Nov 6, 2017
Analysis: The code directly checks for a file under
So we need to check for the existence of a zoneinfo dir first, and then check for the file inside the dir if it exists and return a similar non
Only thing is, I will need to copy over a minimal implementation of
Will send a CL.