Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: fix another 400 year offset in comment #21043

Closed
markus-oberhumer opened this issue Jul 17, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@markus-oberhumer
Copy link

commented Jul 17, 2017

Found by inspecting time/time.go after reading Russ' recent Go Blog entry.

Looks like an oversight in git commit d93f3b5 .

What version of Go are you using (go version)?

Current go 1.9.x-git 504deee .

What did you do?

$ git diff 504deee6088c2448fc3e91c94a1ba69ec92fb7ef
diff --git a/src/time/time.go b/src/time/time.go
index 0a83543e8a..8a29eef263 100644
--- a/src/time/time.go
+++ b/src/time/time.go
@@ -370,7 +370,7 @@ func (d Weekday) String() string { return days[d] }
 // everywhere.
 //
 // The calendar runs on an exact 400 year cycle: a 400-year calendar
-// printed for 1970-2469 will apply as well to 2370-2769. Even the days
+// printed for 1970-2369 will apply as well to 2370-2769. Even the days
 // of the week match up. It simplifies the computations to choose the
 // cycle boundaries so that the exceptional years are always delayed as
 // long as possible. That means choosing a year equal to 1 mod 400, so
@ALTree

This comment has been minimized.

Copy link
Member

commented Jul 17, 2017

Want to send a gerrit change?

@ALTree ALTree added this to the Go1.10 milestone Jul 17, 2017

@markus-oberhumer

This comment has been minimized.

Copy link
Author

commented Jul 17, 2017

I don't have a Gerrit account and a CLA yet, so please feel free to fix this trivial issue by yourself.

@gopherbot

This comment has been minimized.

Copy link

commented Jul 17, 2017

CL https://golang.org/cl/49230 mentions this issue.

@ALTree

This comment has been minimized.

Copy link
Member

commented Jul 17, 2017

@gopherbot gopherbot closed this in 4522efb Jul 17, 2017

@golang golang locked and limited conversation to collaborators Jul 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.