Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
cmd/pprof: update the vendored tool from upstream #21047
Opening this to document a recent (failed) effort to update
The tool was successfully updated from upstream on March 1 (CL 37652). A failed attempt to a final update for go1.9 was made on June 20 (CL 46155). The update broke several builders and was immediately reverted.
The failing builders:
To sum it up: all the failures are on the
google/pprof#169 should fix the file system related issue on Android.
Is it possible to add building and testing of google/pprof at tip to the Go build matrix, "Sub-repositories at tip" section? This would continuously ensure that pprof is Go vendoring ready.
I can do that, but what platforms are you interested in? For example, we have an OSX10.8 builder but not an OSX10.8 trybot. Builders run on master after a commit, trybots can be used to test a change before committing it.
So even if I upload a change and run the trybots on it, they won't tell us if the OSX10.8 issue is gone. In fact, with the old failed update in June the trybots said "OK" on my change and only after it was merged I noticed the OSX10.8, OSX10.10 and iPhone failures (by looking at the builders webpage).
Update vendored pprof to commit 4fc39a00b6b8c1aad05260f01429ec70e127252c from github.com/google/pprof (2017-11-01). Fixes #19380 Updates #21047 Change-Id: Ib64a94a45209039e5945acbcfa0392790c8ee41e Reviewed-on: https://go-review.googlesource.com/57370 Run-TryBot: Alberto Donizetti <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Brad Fitzpatrick <firstname.lastname@example.org> Reviewed-by: Ian Lance Taylor <email@example.com>