New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: run github.com/golang/gddo as part of Trybots #21071

Open
kevinburke opened this Issue Jul 18, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@kevinburke
Contributor

kevinburke commented Jul 18, 2017

I think this should be possible now since github.com/golang/gddo vendors all of its dependencies, and ported to App Engine Flex, so it should just run.

That said, the gddo build is currently failing (golang/gddo#499), so adding this would block successful trybots builds, I think.

cc @shantuo @broady

@gopherbot gopherbot added this to the Unreleased milestone Jul 18, 2017

@gopherbot gopherbot added the Builders label Jul 18, 2017

@kevinburke

This comment has been minimized.

Contributor

kevinburke commented Jul 18, 2017

Because I just looked this up and so I don't forget, if we do want to turn this on I believe the correct place to add the change is in app/build/dash.go as an entry in the goPackages array

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment