Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: run github.com/golang/gddo as part of Trybots #21071

Closed
kevinburke opened this issue Jul 18, 2017 · 5 comments
Closed

x/build: run github.com/golang/gddo as part of Trybots #21071

kevinburke opened this issue Jul 18, 2017 · 5 comments
Assignees
Labels
Milestone

Comments

@kevinburke
Copy link
Contributor

@kevinburke kevinburke commented Jul 18, 2017

I think this should be possible now since github.com/golang/gddo vendors all of its dependencies, and ported to App Engine Flex, so it should just run.

That said, the gddo build is currently failing (golang/gddo#499), so adding this would block successful trybots builds, I think.

cc @shantuo @broady

@gopherbot gopherbot added this to the Unreleased milestone Jul 18, 2017
@gopherbot gopherbot added the Builders label Jul 18, 2017
@kevinburke

This comment has been minimized.

Copy link
Contributor Author

@kevinburke kevinburke commented Jul 18, 2017

Because I just looked this up and so I don't forget, if we do want to turn this on I believe the correct place to add the change is in app/build/dash.go as an entry in the goPackages array

@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Apr 3, 2019

@dmitshur @katiehockman, is there interest in hooking up gddo to Go's test infrastructure or do y'all have some other plan for testing?

@dmitshur

This comment has been minimized.

Copy link
Member

@dmitshur dmitshur commented Apr 3, 2019

I think the interest is low. The current testing strategy is the person submitting a CL runs tests locally before submitting.

The volume of development in gddo is very low right now, and we're heading towards freezing it after some time. Parts of its codebase are unused and in poor/very outdated state, so it might cause extra effort to get it to a point where trybots can succeed. It's also using a somewhat unusual import path setup (see issue golang/gddo#470). I don't expect it to be worthwhile at this time.

@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Apr 3, 2019

The current testing strategy is the person submitting a CL runs tests locally before submitting.

I guess that works when the number of supported platforms is 1. :-)

Okay, will close.

@bradfitz bradfitz closed this Apr 3, 2019
@dmitshur

This comment has been minimized.

Copy link
Member

@dmitshur dmitshur commented Apr 19, 2019

@bradfitz I've remembered that we also have post-submit builders via Travis CI on that repo. I.e., https://travis-ci.org/golang/gddo/builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.