-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build/cmd/gopherbot, x/build/maintner: handle non-Go Github issue repos like gddo #21072
Comments
We'd need to update this call in cmd/gopherbot/gopherbot.go: func (b *gopherbot) initCorpus() {
ctx := context.Background()
corpus, err := godata.Get(ctx) to fetch the gddo Gerrit and Github repositories as well, then modify the logic in the "CL X mentions this issue" function. This might be a good issue for a new contributor. |
CC @bradfitz cf: #22428 (comment) https://go-review.googlesource.com/c/oauth2/+/24946 subrepo oauth2 is being pointed to in a hyperlink on the above CL the intended issue was however a go repo one and not a subrepo issue factually a subrepo was pointed to in a hyperlink of a CL |
Edit: I think I misunderstood what this issue was about. It's not about just adding support for non-Go issue trackers (which is done), but rather for supporting links to those in context of gopherbot. Sorry. |
Was this an isolated occurrence? https://go-review.googlesource.com/c/oauth2/+/24946
For comparison. https://go-review.googlesource.com/c/arch/+/24972
I don't know what volume of data is being dealt with, but CLs might be searched for links pointing to subrepos. Pour faire l'Archiviste il faut être un homme intelligent. |
https://github.com/golang/gddo has a separate issue tracker, but gopherbot ("CL X mentions this issue") can only comment on golang/go repos.
We might also need to update parseGithubRefs in maintner/github.go but at first look at that function makes it seem like it is capable of doing the right thing.
The text was updated successfully, but these errors were encountered: