Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot, x/build/maintner: handle non-Go Github issue repos like gddo #21072

Open
kevinburke opened this issue Jul 18, 2017 · 4 comments

Comments

@kevinburke
Copy link
Contributor

commented Jul 18, 2017

https://github.com/golang/gddo has a separate issue tracker, but gopherbot ("CL X mentions this issue") can only comment on golang/go repos.

We might also need to update parseGithubRefs in maintner/github.go but at first look at that function makes it seem like it is capable of doing the right thing.

@gopherbot gopherbot added this to the Unreleased milestone Jul 18, 2017

@gopherbot gopherbot added the Builders label Jul 18, 2017

@kevinburke

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2017

We'd need to update this call in cmd/gopherbot/gopherbot.go:

func (b *gopherbot) initCorpus() {
	ctx := context.Background()
	corpus, err := godata.Get(ctx)

to fetch the gddo Gerrit and Github repositories as well, then modify the logic in the "CL X mentions this issue" function.

This might be a good issue for a new contributor.

@forskning

This comment has been minimized.

Copy link

commented Oct 26, 2017

CC @bradfitz

cf: #22428 (comment)

https://go-review.googlesource.com/c/oauth2/+/24946

subrepo oauth2 is being pointed to in a hyperlink on the above CL

the intended issue was however a go repo one and not a subrepo issue

factually a subrepo was pointed to in a hyperlink of a CL

@dmitshur

This comment has been minimized.

Copy link
Member

commented Apr 10, 2018

I believe this is done, at least on the x/build/maintner side. In the *maintner.Corpus (from x/build/maintner/godata), the issue tracker of golang/gddo GitHub repo has 96 open issues and 304 closed issues right now. That matches the counts at https://github.com/golang/gddo/issues exactly.

Is there anything else that needs to be done here @kevinburke?

Edit: I think I misunderstood what this issue was about. It's not about just adding support for non-Go issue trackers (which is done), but rather for supporting links to those in context of gopherbot. Sorry.

@forskning

This comment has been minimized.

Copy link

commented Apr 10, 2018

Was this an isolated occurrence?

https://go-review.googlesource.com/c/oauth2/+/24946

Merged

Updated
Jul 15, 2016

Updates golang/go#11811

https://github.com/golang/oauth2/issues/11811
404 This is not the web page you are looking for.

https://github.com/golang/go/issues/11811
all: subrepos need to be green #11811

For comparison.

https://go-review.googlesource.com/c/arch/+/24972

Merged

Updated
Jul 15, 2016

Updates golang/go#11811

https://github.com/golang/go/issues/11811
all: subrepos need to be green #11811

I don't know what volume of data is being dealt with, but CLs might be searched for links pointing to subrepos.

Pour faire l'Archiviste il faut être un homme intelligent.
Un homme intelligent ne fait pas l'Archiviste.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.