Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/godoc: {tip,beta}.golang.org should redirect to https #21073

Closed
dmitshur opened this issue Jul 18, 2017 · 4 comments

Comments

Projects
None yet
5 participants
@dmitshur
Copy link
Member

commented Jul 18, 2017

http://golang.org redirects to https://golang.org (as do blog, tour, etc., subdomains), but http://beta.golang.org and http://tip.golang.org do not redirect to their https equivalent.

Is this an oversight? Or is it intentional (e.g., because it's needed for testing, or because it's too hard to redirect those domains)?

Unless there's a good reason for it, they should redirect to https. It's inconvenient and uses up people's time having to manually modify URLs to https form when visiting or sharing/pasting URLs.

@dmitshur dmitshur added the Security label Jul 18, 2017

@bradfitz

This comment has been minimized.

Copy link
Member

commented Jul 18, 2017

No reason.

Because it was easiest, perhaps.

@bradfitz bradfitz changed the title http://{tip,beta}.golang.org should redirect to https. x/tools/cmd/godoc: {tip,beta}.golang.org should redirect to https Jul 18, 2017

@gopherbot gopherbot added this to the Unreleased milestone Jul 18, 2017

@kevinburke

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2017

previously: #19759

@agnivade

This comment has been minimized.

Copy link
Member

commented Mar 23, 2018

Just wanted to mention that tip.golang.org redirects to https now. I can send a CL to make the change for beta.golang.org also, if somebody can point out where to make that change.

For tip, there is a special x/tools/cmd/tip, I don't see anything like that for beta.golang.org. There is just this comment inside cmd/godoc/autocert.go though.

// TODO: make this the default? We're in the Go 1.8 freeze now, so
// this is too invasive to be default, but we want it for
// https://beta.golang.org/
@gopherbot

This comment has been minimized.

Copy link

commented Oct 17, 2018

Change https://golang.org/cl/120056 mentions this issue: cmd/tip: make tip.golang.org also serve & redirect beta.golang.org to tip

bradfitz added a commit to bradfitz/build that referenced this issue Feb 1, 2019

cmd/tip: make tip.golang.org also serve & redirect beta.golang.org to…
… tip

We're turning down the old (and neglected) beta.golang.org godoc VM.
It's not different enough from tip.golang.org, which is more reliable
than it used to be.

Now beta.golang.org will just redirect to tip.

Updates golang/go#25978
Fixes golang/go#21073

Change-Id: Iae7fe4c82c14cec7381e75a2e214210d38b6e623
Reviewed-on: https://go-review.googlesource.com/c/120056
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.