Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/maintner: load tokens from XDG config dir #21087

Open
kevinburke opened this issue Jul 19, 2017 · 3 comments

Comments

@kevinburke
Copy link
Contributor

commented Jul 19, 2017

Right now we hardcode the file to get Github tokens from as $HOME/.github-issue-token. If a user has XDG_CONFIG_HOME specified we should try to load tokens from there too.

@gopherbot gopherbot added this to the Unreleased milestone Jul 19, 2017

@gopherbot gopherbot added the Builders label Jul 19, 2017

@bradfitz

This comment has been minimized.

Copy link
Member

commented Jul 19, 2017

I guess.

But the XDG spec says that $HOME/.config is the default if it's not specified. So I wouldn't say that this bug is only about if XDG_CONFIG_HOME is set.

I'd just also include the config dir in the search, but keep the existing one.

I've written the XDG search stuff a dozen times.

@gopherbot

This comment has been minimized.

Copy link

commented Jul 19, 2017

CL https://golang.org/cl/50090 mentions this issue.

@kevinburke

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2017

Implemented per your suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.