Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: extra space in panic message #21102

Closed
kanata2 opened this issue Jul 20, 2017 · 2 comments
Closed

net/http: extra space in panic message #21102

kanata2 opened this issue Jul 20, 2017 · 2 comments

Comments

@kanata2
Copy link
Contributor

@kanata2 kanata2 commented Jul 20, 2017

In net/http/server.go,

if pattern == "" {
    panic("http: invalid pattern " + pattern)
}

I think the last space of "http: invalid pattern " and + pattern are unnecessary because pattern is an empty string, so please review this 馃檹
I'll send a change request if there is no problem.

@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Jul 20, 2017

Yeah, that looks like a copy/paste oversight from a few lines later.

Sure, send a change.

@bradfitz bradfitz added this to the Go1.10 milestone Jul 20, 2017
@bradfitz bradfitz added the NeedsFix label Jul 20, 2017
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jul 20, 2017

CL https://golang.org/cl/50350 mentions this issue.

@gopherbot gopherbot closed this in d6cada7 Aug 15, 2017
@golang golang locked and limited conversation to collaborators Aug 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can鈥檛 perform that action at this time.