Skip to content

x/review/git-codereview: use rebase branch during rebase #21164

@aclements

Description

@aclements

Currently git-codereview doesn't add the appropriate "[branch]" prefix to commit messages created or amended during a rebase because all it sees is the detached HEAD state. As a fall back, it could look for .git/rebase-merge/head-name, which contains the full ref name of the branch being rebased and find that branch's upstream.

For example, this happened in https://golang.org/cl/50875.

/cc @josharian

Metadata

Metadata

Assignees

No one assigned

    Labels

    SuggestedIssues that may be good for new contributors looking for work to do.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions