Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/review/git-codereview: use rebase branch during rebase #21164

Open
aclements opened this issue Jul 25, 2017 · 1 comment
Open

x/review/git-codereview: use rebase branch during rebase #21164

aclements opened this issue Jul 25, 2017 · 1 comment
Labels
Suggested Issues that may be good for new contributors looking for work to do.
Milestone

Comments

@aclements
Copy link
Member

Currently git-codereview doesn't add the appropriate "[branch]" prefix to commit messages created or amended during a rebase because all it sees is the detached HEAD state. As a fall back, it could look for .git/rebase-merge/head-name, which contains the full ref name of the branch being rebased and find that branch's upstream.

For example, this happened in https://golang.org/cl/50875.

/cc @josharian

@gopherbot gopherbot added this to the Unreleased milestone Jul 25, 2017
@josharian josharian added the Suggested Issues that may be good for new contributors looking for work to do. label Jul 25, 2017
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/375174 mentions this issue: git-codereview: hook: fixCommitMessage: improve upstream branch detection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Development

No branches or pull requests

3 participants