Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: Incorrect Comment & Ordering in AMD64 Operations #21225

Closed
luccacabra opened this issue Jul 31, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@luccacabra
Copy link

commented Jul 31, 2017

Please answer these questions before submitting your issue. Thanks!

What did you do?

If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

Reviewing file:

{name: "ADDSDmem", argLength: 3, reg: fp21load, asm: "ADDSD", aux: "SymOff", resultInArg0: true, faultOnNilArg1: true, symEffect: "Read"}, // fp32 arg0 + tmp, tmp loaded from arg1+auxint+aux, arg2 = mem

What did you expect to see?

ADDSD referenced as using fp64 args in its operation comment, and (nitpick) comes after the ADDSS op code in its respective code block.

What did you see instead?

ADDSD referenced as using fp32 args in its operation comment, and (nitpick) comes before the ADDSS op code in its respective code block.

System details

go version go1.8.3 darwin/amd64
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/jlucci/indeed/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/jz/dt5gn4qx7_qgjk9k9fphpqj00000gn/T/go-build994161812=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
GOROOT/bin/go version: go version go1.8.3 darwin/amd64
GOROOT/bin/go tool compile -V: compile version go1.8.3 X:framepointer
uname -v: Darwin Kernel Version 16.6.0: Fri Apr 14 16:21:16 PDT 2017; root:xnu-3789.60.24~6/RELEASE_X86_64
ProductName:	Mac OS X
ProductVersion:	10.12.5
BuildVersion:	16F73
lldb --version: lldb-370.0.42
  Swift-3.1

@bradfitz bradfitz changed the title Incorrect Comment & Ordering in AMD64 Operations cmd/compile: Incorrect Comment & Ordering in AMD64 Operations Jul 31, 2017

@bradfitz bradfitz added this to the Go1.10 milestone Jul 31, 2017

@bradfitz

This comment has been minimized.

Copy link
Member

commented Jul 31, 2017

@gopherbot

This comment has been minimized.

Copy link

commented Jul 31, 2017

Change https://golang.org/cl/52071 mentions this issue: cmd/compile: fix ADDSDmem comment and order in list

@gopherbot gopherbot closed this in d3c0af7 Aug 8, 2017

@golang golang locked and limited conversation to collaborators Aug 8, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.