Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upnet: DialContextTCP() #21231
Comments
This comment has been minimized.
This comment has been minimized.
|
Did you miss https://golang.org/pkg/net/#Dialer.DialContext ? |
This comment has been minimized.
This comment has been minimized.
|
@fraenkel no. conn, err := dialer.DialContext(...)Does not allow me to setup local address for connection. |
This comment has been minimized.
This comment has been minimized.
|
Sure it can. Set the LocalAddress in the Dialer. |
This comment has been minimized.
This comment has been minimized.
|
@fraenkel wow. Thanks! Seems like I really missed this. |
This comment has been minimized.
This comment has been minimized.
|
I don't think so. We just need to adequately highlight the proper APIs that people should use. The original ones were modified to leverage the Context based ones but cannot be removed for compatibility reasons. |
This comment has been minimized.
This comment has been minimized.
|
Closing since there doesn't seem to be anything to do here. |
ianlancetaylor
closed this
Aug 1, 2017
golang
locked and limited conversation to collaborators
Aug 1, 2018
gopherbot
added
the
FrozenDueToAge
label
Aug 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
gobwas commentedJul 31, 2017
Hello! I've search for some similar issues and found this one but looks like it is stale now.
My issue points to inability to dial via tcp with custom
context.Contextpassed.Current implementation of
net.DialTCP()(actuallynet.dialTCP) is absolutely ready to receive context for dial, but has no exported wrapper that can receive it.