Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/godoc: golang.org/cl redirect leads to blank page for all CLs. #21240

Closed
dmitshur opened this issue Jul 31, 2017 · 5 comments

Comments

Projects
None yet
6 participants
@dmitshur
Copy link
Member

commented Jul 31, 2017

I'm not sure if this is a temporary issue that's already being worked on (e.g. https://twitter.com/bradfitz/status/892055083092815874 aka #21237), or an unrelated legitimate issue. I'll report it so it can be triaged.

The following URL:

https://golang.org/cl/47352

Redirects to:

https://go-review.googlesource.com/c/gddo/%20/47352/

Which appears as a blank white page:

image

Happens whether I'm logged in or in incognito window. I tried clearing all cache.

On the other hand, modifying the URL to:

https://go-review.googlesource.com/c/47352/

It works okay:

image

This seems to affect all CLs, not just gddo ones, as far as I can tell. E.g., https://golang.org/cl/50990 (main repo CL) and https://golang.org/cl/43812 (x/tools CL) are affected too.

I don't know if the issue is that the first URL should work, but doesn't, or that the golang.org/cl redirect should point to second URL directly. /cc @bradfitz

@dlsniper

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2017

duplicate of #21235 ?

@bradfitz

This comment has been minimized.

Copy link
Member

commented Jul 31, 2017

Yup.

@bradfitz bradfitz closed this Jul 31, 2017

@dmitshur

This comment has been minimized.

Copy link
Member Author

commented Jul 31, 2017

Yes, looks like a duplicate. I didn't find it because it's closed, but the issue isn't actually resolved yet. Maybe we should reopen it with an "external" label or something, and close when the actual issue is resolved (since it might take a few days)?

@andybons

This comment has been minimized.

Copy link
Member

commented Jul 31, 2017

@broady is deploying the fix soon

@broady

This comment has been minimized.

Copy link
Member

commented Jul 31, 2017

Deployed

@mikioh mikioh changed the title golang.org/cl redirect leads to blank page for all CLs. x/tools/cmd/godoc: golang.org/cl redirect leads to blank page for all CLs. Aug 2, 2017

@golang golang locked and limited conversation to collaborators Aug 2, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.