cmd/compile/internal/types: concurrent map read and map write while compiling #21352
one builder failed with what it seems to be a map read / write race during compilation:
at tip 64bd2c4
While the read location seems clear the write location does not seem to be in the trace.
The text was updated successfully, but these errors were encountered:
I think CL 54090 should be cherry-picked to 1.9. (Thanks so very much for noticing and filing an issue, @martisch.)
The alternative for 1.9 is to disable concurrent compilation for GO386=387 in cmd/go and cmd/compile, but I think the proper fix is very low risk, perhaps even lower risk than the alternative.
Updates #21352 Change-Id: If21342f30be32e25840b4072b932a6d4257b420d Reviewed-on: https://go-review.googlesource.com/54091 Run-TryBot: Josh Bleecher Snyder <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Avelino <firstname.lastname@example.org> Reviewed-by: Matthew Dempsky <email@example.com>
…backend [This is a cherry-pick of CL 54090 to the 1.9 release branch.] gc.Sysfunc must not be called concurrently. We set up runtime routines used by the backend prior to doing any backend compilation. I missed the 387 ones; fix that. Sysfunc should have been unexported during 1.9. I will rectify that in a subsequent CL. Fixes #21352 Change-Id: I485bb1867b46d8e5cf64bc820b8963576dc16174 Reviewed-on: https://go-review.googlesource.com/55970 Run-TryBot: Josh Bleecher Snyder <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Keith Randall <firstname.lastname@example.org>