Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509: CreateCertificate docs incompletely list template fields used #21363

Closed
cryslith opened this issue Aug 9, 2017 · 3 comments
Closed

Comments

@cryslith
Copy link

@cryslith cryslith commented Aug 9, 2017

Similarly to #18962, the following fields of template are used by x509.CreateCertificate but are not listed as being used by that function in the docs:

  • ExtraExtensions
  • OCSPServer
  • IssuingCertificateURL
  • EmailAddresses
  • IPAddresses
  • PolicyIdentifiers
  • CRLDistributionPoints

(They are all used in buildExtensions, called by CreateCertificate).

@cryslith cryslith changed the title crypto/x509: CreateCertificate{,Request} docs incompletely list template fields used crypto/x509: CreateCertificate docs incompletely list template fields used Aug 9, 2017
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Mar 30, 2018

@ianlancetaylor ianlancetaylor added this to the Unplanned milestone Mar 30, 2018
@gopherbot
Copy link

@gopherbot gopherbot commented May 20, 2018

Change https://golang.org/cl/113916 mentions this issue: crypto/x509: document fields used in CreateCertificate

@martin-sucha
Copy link
Contributor

@martin-sucha martin-sucha commented May 20, 2018

@gopherbot gopherbot closed this in a10d390 May 22, 2018
@golang golang locked and limited conversation to collaborators May 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.