Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/ssh: docs for SignCert omit mention of nonce #21384

Open
ichung opened this Issue Aug 10, 2017 · 3 comments

Comments

Projects
None yet
5 participants
@ichung
Copy link

ichung commented Aug 10, 2017

The documentation for Certificate.SignCert should note that it automatically sets c.Nonce to a 32-byte random nonce before signing.

@gopherbot gopherbot added this to the Unreleased milestone Aug 10, 2017

@jakob223

This comment has been minimized.

Copy link
Contributor

jakob223 commented Aug 18, 2017

Add the relevant lines to the doc: https://go-review.googlesource.com/57051

@meirf

This comment has been minimized.

Copy link
Contributor

meirf commented Jul 6, 2018

@tklauser any interest in reviewing this small change? I think "random" is useful since it implies that it's using the rand io.Reader argument.

@tklauser

This comment has been minimized.

Copy link
Member

tklauser commented Jul 6, 2018

@meirf thanks. I'm not familiar with this code, but I've added @FiloSottile as a reviewer to have a look at the CL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.