Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/ssh: docs for SignCert omit mention of nonce #21384

Closed
cryslith opened this issue Aug 10, 2017 · 6 comments
Closed

x/crypto/ssh: docs for SignCert omit mention of nonce #21384

cryslith opened this issue Aug 10, 2017 · 6 comments
Labels
Milestone

Comments

@cryslith
Copy link

@cryslith cryslith commented Aug 10, 2017

The documentation for Certificate.SignCert should note that it automatically sets c.Nonce to a 32-byte random nonce before signing.

@gopherbot gopherbot added this to the Unreleased milestone Aug 10, 2017
@jakob223
Copy link
Contributor

@jakob223 jakob223 commented Aug 18, 2017

Add the relevant lines to the doc: https://go-review.googlesource.com/57051

@meirf
Copy link
Contributor

@meirf meirf commented Jul 6, 2018

@tklauser any interest in reviewing this small change? I think "random" is useful since it implies that it's using the rand io.Reader argument.

@tklauser
Copy link
Member

@tklauser tklauser commented Jul 6, 2018

@meirf thanks. I'm not familiar with this code, but I've added @FiloSottile as a reviewer to have a look at the CL.

@cryslith
Copy link
Author

@cryslith cryslith commented Apr 19, 2020

Hi, I'd like to fix this. Is there a way for me to "adopt" the change that @jakob223 started, or should I create a new changeset?

@tklauser
Copy link
Member

@tklauser tklauser commented Apr 20, 2020

Hi, I'd like to fix this. Is there a way for me to "adopt" the change that @jakob223 started, or should I create a new changeset?

@cryslith feel free to send a new CL, I don't think there is a way to adopt a CL.

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 27, 2020

Change https://golang.org/cl/230212 mentions this issue: ssh: improve docs on Certificate.SignCert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.