cmd/vendor/golang.org/x/arch/arm64/arm64asm: tests fail on tip

[YoshikiShibata]

Please answer these questions before submitting your issue. Thanks!

What did you do?

Rebuild the lastest tip with all.bash.

What did you expect to see?

Build didn't fail.

What did you see instead?

ok  	cmd/vendor/github.com/google/pprof/internal/binutils	0.183s
ok  	cmd/vendor/github.com/google/pprof/internal/driver	2.079s
ok  	cmd/vendor/github.com/google/pprof/internal/elfexec	0.015s
ok  	cmd/vendor/github.com/google/pprof/internal/graph	0.020s
ok  	cmd/vendor/github.com/google/pprof/internal/report	0.021s
ok  	cmd/vendor/github.com/google/pprof/internal/symbolizer	0.030s
ok  	cmd/vendor/github.com/google/pprof/internal/symbolz	0.017s
ok  	cmd/vendor/github.com/google/pprof/profile	0.111s
ok  	cmd/vendor/github.com/ianlancetaylor/demangle	0.046s
ok  	cmd/vendor/golang.org/x/arch/arm/armasm	0.034s
2017/08/17 07:37:49 exit status 1
FAIL	cmd/vendor/golang.org/x/arch/arm64/arm64asm	0.635s
ok  	cmd/vendor/golang.org/x/arch/ppc64/ppc64asm	0.020s
ok  	cmd/vendor/golang.org/x/arch/x86/x86asm	0.171s
ok  	cmd/vet	3.696s
ok  	cmd/vet/internal/cfg	0.017s
2017/08/17 07:39:02 Failed: exit status 1

real	5m8.927s
user	11m15.372s
sys	2m52.925s

Does this issue reproduce with the latest release (go1.8.3)?

N/A

System details

go version devel +78984d3954 Wed Aug 16 22:22:19 2017 +0000 darwin/amd64
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/yoshiki/gocode:/Users/yoshiki/exercises/gpl:/Users/yoshiki/oak"
GORACE=""
GOROOT="/Users/yoshiki/tools/go"
GOTOOLDIR="/Users/yoshiki/tools/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/pb/c7_4_d355ng5zfm4r_jg2gg00000gn/T/go-build681318826=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOROOT/bin/go version: go version devel +78984d3954 Wed Aug 16 22:22:19 2017 +0000 darwin/amd64
GOROOT/bin/go tool compile -V: compile version devel +78984d3954 Wed Aug 16 22:22:19 2017 +0000
uname -v: Darwin Kernel Version 16.7.0: Thu Jun 15 17:36:27 PDT 2017; root:xnu-3789.70.16~2/RELEASE_X86_64
ProductName:	Mac OS X
ProductVersion:	10.12.6
BuildVersion:	16G29
lldb --version: lldb-370.0.42
  Swift-3.1

[dmitshur]

According to https://build.golang.org/#short, it looks like CL 49530 is the first bad commit. /cc @williamweixiao @cherrymui

It seems to be affecting only macOS 10.12, but not 10.11, 10.10, 10.8. Also linux-arm64-buildlet and linux-arm64-packet, but not other types of Linux.

[gopherbot]

Change https://golang.org/cl/56331 mentions this issue: cmd/vendor/golang.org/x/arch/arm64/arm64asm: skip TestObjdumpARM64* if in short mode

[gopherbot]

Change https://golang.org/cl/56450 mentions this issue: arm64/arm64asm: skip external objdump test if running "objdump -i" fails

[gopherbot]

Change https://golang.org/cl/56810 mentions this issue: x/arch/arm64: refine objdump test to avoid false alarm

[gopherbot]

Change https://golang.org/cl/56971 mentions this issue: arm64/arm64asm: avoid log.Fatal during test

[gopherbot]

Change https://golang.org/cl/57030 mentions this issue: cmd/vendor/golang.org/x/arch: import latest (Aug 18 2017 ffd22fb365cd)

[cherrymui]

Reopen. ARM64 failure is still not fixed. A revised CL https://golang.org/cl/56810 should handle it.

[cherrymui]

Fixed in x/arch subrepo. Reopen for vendoring into main repo.