Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Windows: MSI Upgrade should default to previous install folder, not insist on C:\Go\ #21609

Open
lkarlslund opened this issue Aug 25, 2017 · 5 comments

Comments

@lkarlslund
Copy link

commented Aug 25, 2017

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

1.9 release

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

Windows

What did you do?

Had Go 1.9rc2 installed in C:\Program Files\Go
Wizard asked if I wanted to uninstall old during upgrade, I chose YES
Wizard asks where I want to install new version, defaults to C:\Go\

What did you expect to see?

I expected it to suggest installation in the previously selected folder, as this is an upgrade, and everything in environment is set for that path.

What did you see instead?

It insists on suggesting C:\Go\ which fills up my root folder with more directories. I don't get it why you don't use Program Files as everything else on Windows. This is not Linux (and you would never suggest to install in /go/ on a Linux system anyway)

@ianlancetaylor ianlancetaylor changed the title Windows: MSI Upgrade should default to previous install folder, not insist on C:\Go\ install: Windows: MSI Upgrade should default to previous install folder, not insist on C:\Go\ Aug 25, 2017

@ianlancetaylor ianlancetaylor added this to the Go1.10 milestone Aug 25, 2017

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2017

CC @broady

@as

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2017

The utility will have to remember where the previous installation occured. How would it do this?

@lkarlslund

This comment has been minimized.

Copy link
Author

commented Sep 11, 2017

@as

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2017

That may be a good option. It seems the installer already places a gift in the registry:

reg query HKCU\software\goprogramminglanguage /v installLocation

HKEY_CURRENT_USER\software\goprogramminglanguage
    installLocation    REG_SZ    C:\Go\

Someone with MSI expertise can take it from here.

@as

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2017

Just for the record, I really like C:\go, especially since you can shorten it to \go. Please don't change the default.

Windows has a Program Files (x86), a ProgramData, a System32 and a SysWow64. There is a 32-bit Notepad.exe in the SysWow64 folder and a 64-bit notepad in the System32 folder. The simplicity of C:\go is deeply appreciated on this system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.