Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: we shouldn't use MOVOstore instruction on plan9/amd64 #21625

Closed
0intro opened this issue Aug 25, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@0intro
Copy link
Member

commented Aug 25, 2017

The SSA compiler currently generates MOVOstore instructions to optimize 16 bytes moves on AMD64 architecture.

These instructions were added in CL 16174.

See AMD64.rules:322 and AMD64.rules:351

However, we can't use the MOVOstore instruction on Plan 9, because floating point operations are not allowed in the note handler.

We should disable use of MOVOstore instruction on Plan 9, using the useSSE flag (disabled on Plan 9).

@0intro 0intro added the OS-Plan9 label Aug 25, 2017

@0intro 0intro added this to the Go1.10 milestone Aug 25, 2017

@0intro 0intro self-assigned this Aug 25, 2017

@gopherbot

This comment has been minimized.

Copy link

commented Aug 25, 2017

Change https://golang.org/cl/59171 mentions this issue: cmd/compile: don't use MOVOstore for move on plan9/amd64

@gopherbot gopherbot closed this in adbfdfe Aug 28, 2017

@golang golang locked and limited conversation to collaborators Aug 28, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.