Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: add Helper to the TB interface #21627

Closed
cespare opened this issue Aug 25, 2017 · 1 comment
Closed

testing: add Helper to the TB interface #21627

cespare opened this issue Aug 25, 2017 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.10

Comments

@cespare
Copy link
Contributor

cespare commented Aug 25, 2017

As part of implementing #4899, I was going to add Helper to the TB interface. This was part of the approved design doc (https://github.com/golang/proposal/blob/master/design/4899-testing-helper.md), but I forgot to do it.

(Note that while it's not normally OK to add to exported interfaces, testing.TB has a private method specifically to allow it to be extended: https://github.com/golang/proposal/blob/master/design/4899-testing-helper.md#compatibility.)
@cespare cespare added this to the Go1.10 milestone Aug 25, 2017
@cespare cespare self-assigned this Aug 25, 2017
@cespare
Copy link
Contributor Author

cespare commented Aug 25, 2017

Wait, it is part of the interface. I misinterpreted the bug report. Sorry for the noise.

@cespare cespare closed this as completed Aug 25, 2017
@golang golang locked and limited conversation to collaborators Aug 25, 2018
@rsc rsc unassigned cespare Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
2 participants
@cespare @gopherbot