Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
x/crypto/ssh: session.Close() should unblock session.Wait() #21699
See #21423 for previous discussion.
referenced this issue
Aug 30, 2017
can you provide more details under what circumstances the Close takes longer to process than the roundtrip that the RFC prescribes for channel close?
I don't think we can trigger the channel close mechanics without receiving an ack from the remote side, as we wouldn't know where to deliver any messages, so it would lead to dropped data.
Nah, I think we're talking about different things. Even with SSH Keep Alive, a poorly implemented ssh server could take forever to respond to a channel close, which would cause session.Wait() to deadlock.
It could handle other requests and respond to keep alive fine, just not respond to the channel close.