Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: constant definitions should not affect inlining budget #21749

Closed
mpx opened this issue Sep 3, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@mpx
Copy link
Contributor

commented Sep 3, 2017

Currently constants defined within a function affect the inlining budget, even though they don't affect code generation. This arbitrarily prevents some functions from being inlined. Moving constants to a global is a workaround, but shouldn't be necessary.

go version devel +03c3bb5

@gopherbot

This comment has been minimized.

Copy link

commented Sep 3, 2017

Change https://golang.org/cl/61250 mentions this issue: cmd/compile: Ignore constant definitions when inlining

@mpx

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2017

@mdempsky mdempsky changed the title Constant definitions should not affect inlining budget cmd/compile: constant definitions should not affect inlining budget Sep 3, 2017

@gopherbot gopherbot closed this in 812b34e Sep 4, 2017

@golang golang locked and limited conversation to collaborators Sep 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.