flag: arg conditional expression can be simplified

[alexpantyukhin]

I have found redundant check in the parseOne() function.

1. https://github.com/golang/go/blob/master/src/flag/flag.go#L842

	if len(s) == 0 || s[0] != '-' || len(s) == 1 {
		return false, nil
	}

is equivalent

	if len(s) < 2 || s[0] != '-' {
		return false, nil
	}

[cznic]

s/remove redundant check/simplify expression/

[mvdan]

@alexpantyukhin feel free to submit a patch - see https://golang.org/doc/contribute.html.

[alexpantyukhin]

@mvdan Thanks! already did. Also reviewing the method I found that flags names allowed to contain almost all characters (for example ".myint", "?/_", "). Is it ok? Are there some constraints for console parameters names?

[mvdan]

Using a proposal for this is overkill, so I've removed it from the proposal list.

I've reviewed your CL. In the future, for such small changes, just post the CL. Even if you're wrong, it can be discussed on Gerrit.

Of course, this wouldn't apply to small changes that would be controversial or that would require lots of design and discussion.

[gopherbot]

Change https://golang.org/cl/61491 mentions this issue: flag: simplify arg logic in parseOne