Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/internal/goobj: TestParseGoobj and TestParseArchive failing on plan9/arm #21817

Closed
0intro opened this issue Sep 9, 2017 · 6 comments
Closed

Comments

@0intro
Copy link
Member

@0intro 0intro commented Sep 9, 2017

CL 60130 added TestParseGoobj and TestParseArchive which are failing on plan9/arm.

--- FAIL: TestParseGoobj (0.06s)
	goobj_test.go:93: corrupt object file
--- FAIL: TestParseArchive (0.03s)
	goobj_test.go:121: parsing archive member "go1.o": corrupt object file
FAIL
FAIL	cmd/internal/goobj	3.666s

See https://build.golang.org/log/22a2cb1bb8d6fe14f7fe9901f10e92bbd741870f

@0intro 0intro added the OS-Plan9 label Sep 9, 2017
@0intro 0intro added this to the Go1.10 milestone Sep 9, 2017
@0intro 0intro self-assigned this Sep 9, 2017
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Sep 9, 2017

CC @hirochachacha

@hirochachacha
Copy link
Contributor

@hirochachacha hirochachacha commented Sep 9, 2017

According to https://build.golang.org/
darwin/arm looks no problem. will skip other arm platforms.

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 9, 2017

Change https://golang.org/cl/62351 mentions this issue: cmd/internal/goobj: skip tests on some $GOOS/arm

@0intro
Copy link
Member Author

@0intro 0intro commented Sep 10, 2017

I can confirm that I get the same behavior as described in issue #19811.

readInt is failing because the 0xebfffffe value can't fit into a 32-bit int.

cpu% go tool dist test -v -run '^go_test:cmd/internal/goobj$'

##### Testing packages.
# go tool dist test -run=^go_test:cmd/internal/goobj$
readInt 0xffffffffebfffffe != 0xebfffffe
--- FAIL: TestParseGoobj (0.02s)
	goobj_test.go:93: corrupt object file
readInt 0xffffffffebfffffe != 0xebfffffe
--- FAIL: TestParseArchive (0.01s)
	goobj_test.go:121: parsing archive member "go1.o": corrupt object file
FAIL
FAIL	cmd/internal/goobj	1.349s

gopherbot pushed a commit that referenced this issue Sep 10, 2017
Updates #21817

Change-Id: I77ffaf8a7e54465a5b73691b896edcb20c29440f
Reviewed-on: https://go-review.googlesource.com/62351
Reviewed-by: David du Colombier <0intro@gmail.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@cherrymui
Copy link
Member

@cherrymui cherrymui commented Nov 21, 2017

I half-fixed #19811 in CL 69010, and unskipped the tests. Should be passing now, right?

@rsc rsc modified the milestones: Go1.10, Go1.11 Dec 4, 2017
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Jun 14, 2018

This should be working now.

@golang golang locked and limited conversation to collaborators Jun 14, 2019
@rsc rsc unassigned 0intro Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants