Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
proposal: crypto/x509: add Public Key Algorithms from RFC 4491 #21858
RFC 4491 describes encoding formats,
It was published at May 2006.
What did you do?
Parsed certificate with GOST R 34.10 Algorithms. Such as:
And tried to get information about public key algorithm:
What did you expect to see?
Expected to see some valid algorithm with value greater then 0:
What did you see instead?
It's unknown algorithm:
0 is the value of
Are you suggesting adding GOST values to
@jeffallen There is precedent with hash functions, but it seemed to always cause more trouble than it's worth. Personally I'd rather make sure stdlib packages are decoupled enough to allow forks to be easily plugged in, allowing more than just adding algorithms without a sprawling plugin interface.
OpenSSL knows about these algorithms even without ability to use it (with disabled GOST engine).
Yes, I suggest to add values to
The reason why this is not yet implemented neither in stdlib, nor x/crypto, is that Java, C# or OpenSSL (via libopenssl, cgo) is used to create signature or encrypt/decrypt some data.
I understand that this is a time-consuming task and therefor I ask about the possibility of adding support
If it is possible then I or someone else can implement it and open a pull request.
If it's not going to be merged then we should add ability to extend functionality of crypto/x509. Right now it is not possible to know OID of unknown algorithm.