Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/pubsubhelper: robot account should be subscribed in config, not manually #21869

Closed
andybons opened this issue Sep 13, 2017 · 2 comments
Closed
Assignees
Milestone

Comments

@andybons
Copy link
Member

@andybons andybons commented Sep 13, 2017

Gerrit removes watches from inactive accounts. The pubsubhelper bot is considered inactive so should have its watches changed from being profile-level to config-level:

an example entry:

[notify "pubsubbot"]
        email = gopherbot@blah.com
        type = all_comments
        type = submitted_changes
        type = ...

/cc @adams-sarah @bradfitz

@andybons andybons self-assigned this Sep 13, 2017
@gopherbot gopherbot added this to the Unreleased milestone Sep 13, 2017
@gopherbot gopherbot added the Builders label Sep 13, 2017
@andybons andybons changed the title x/build/pubsubhelper: robot account should be subscribed in config, not manually x/build/cmd/pubsubhelper: robot account should be subscribed in config, not manually Sep 13, 2017
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Sep 17, 2017

Good to know! Thanks.

@andybons
Copy link
Member Author

@andybons andybons commented Sep 19, 2017

Pushed config change to AllProjects. We shouldn't have to log in to the bot account again. 🎉

@andybons andybons closed this Sep 19, 2017
@golang golang locked and limited conversation to collaborators Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.