Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/rsa: reject short signatures #21896

Open
rsc opened this issue Sep 14, 2017 · 1 comment

Comments

@rsc
Copy link
Contributor

commented Sep 14, 2017

During dev.boringcrypto work, I discovered that x/crypto/openpgp tests depend on crypto/rsa accepting trimmed RSA signatures, in which leading zeros have been removed, while BoringSSL does not. @agl says that the Go library is in error and that such signatures are not valid. We should fix this (in master, not just dev.boringcrypto) for Go 1.10 and mark it in the release notes. Will need to fix openpgp first.

@rsc rsc added this to the Go1.10 milestone Sep 14, 2017
@rsc rsc modified the milestones: Go1.10, Go1.11 Nov 22, 2017
@FiloSottile FiloSottile modified the milestones: Go1.11, Go1.12 Jul 16, 2018
@FiloSottile FiloSottile removed the Security label Jul 16, 2018
@FiloSottile

This comment has been minimized.

Copy link
Member

commented Jul 16, 2018

This is very likely to break people, and unlikely to be a security issue (unless someone is relying on verifiable signatures not being malleable, but that is often regrettable anyway) so let's do it in early 1.12 instead of late 1.11.

@andybons andybons modified the milestones: Go1.12, Go1.13 Nov 28, 2018
@bradfitz bradfitz modified the milestones: Go1.13, Go1.14 May 16, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.