Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: database/sql: support default valueConverter per driver #21930

Closed
bgaifullin opened this issue Sep 19, 2017 · 3 comments
Closed

proposal: database/sql: support default valueConverter per driver #21930

bgaifullin opened this issue Sep 19, 2017 · 3 comments

Comments

@bgaifullin
Copy link
Contributor

@bgaifullin bgaifullin commented Sep 19, 2017

I want to use type []T in ExecerContext and QueryerContext since clickhouse implements support for array, but I cannot not, because database/sql does not allow me pass this type to driver.

I want to specify custom ValueConverter in my driver, which will be used instead of defaultValueConverter in func (db *DB) QueryContext and func (db *DB) ExecContext

clickhouse driver: https://github.com/mailru/go-clickhouse

@gopherbot gopherbot added this to the Proposal milestone Sep 19, 2017
@gopherbot gopherbot added the Proposal label Sep 19, 2017
@rsc
Copy link
Contributor

@rsc rsc commented Sep 25, 2017

@kardianos
Copy link
Contributor

@kardianos kardianos commented Sep 25, 2017

The driver should implement https://godoc.org/database/sql/driver#NamedValueChecker (added as of go1.9).

@bgaifullin
Copy link
Contributor Author

@bgaifullin bgaifullin commented Sep 26, 2017

Thanks

@kardianos kardianos closed this Sep 26, 2017
@golang golang locked and limited conversation to collaborators Sep 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.