Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: builders unable to build App Engine apps due to missing packages #21949

Closed
andybons opened this issue Sep 20, 2017 · 3 comments
Closed

x/build: builders unable to build App Engine apps due to missing packages #21949

andybons opened this issue Sep 20, 2017 · 3 comments

Comments

@andybons
Copy link
Member

@andybons andybons commented Sep 20, 2017

All failures at https://go-review.googlesource.com/c/playground/+/64690#message-087a81db71034399093f315c9456bf468bcd006d

Example log from linux amd64 builder:

linux-amd64 at c100a0f6680318cb0511b0ecebccb1cdf0eae9b3 building playground at cc9bf7a3cda55e6694065cfbdbcb73b49ec24233

../../gopath/src/golang.org/x/playground/app/goplay/compile.go:12:2: cannot find package "google.golang.org/appengine" in any of:
	/tmp/workdir/go/src/google.golang.org/appengine (from $GOROOT)
	/tmp/workdir/gopath/src/google.golang.org/appengine (from $GOPATH)
../../gopath/src/golang.org/x/playground/app/goplay/edit.go:14:2: cannot find package "google.golang.org/appengine/datastore" in any of:
	/tmp/workdir/go/src/google.golang.org/appengine/datastore (from $GOROOT)
	/tmp/workdir/gopath/src/google.golang.org/appengine/datastore (from $GOPATH)
../../gopath/src/golang.org/x/playground/app/goplay/compile.go:13:2: cannot find package "google.golang.org/appengine/log" in any of:
	/tmp/workdir/go/src/google.golang.org/appengine/log (from $GOROOT)
	/tmp/workdir/gopath/src/google.golang.org/appengine/log (from $GOPATH)
../../gopath/src/golang.org/x/playground/app/goplay/compile.go:14:2: cannot find package "google.golang.org/appengine/urlfetch" in any of:
	/tmp/workdir/go/src/google.golang.org/appengine/urlfetch (from $GOROOT)
	/tmp/workdir/gopath/src/google.golang.org/appengine/urlfetch (from $GOPATH)


Error: tests failed: exit status 1
@gopherbot gopherbot added this to the Unreleased milestone Sep 20, 2017
@gopherbot gopherbot added the Builders label Sep 20, 2017
@adams-sarah

This comment has been minimized.

Copy link
Contributor

@adams-sarah adams-sarah commented Sep 29, 2017

So first off, it doesn't look as though trybots have ever been run for playground before (though, I only looked back two years).

Additionally, I cannot find another subrepo with trybot support which has external dependencies (though I didn't look through all of them, just a few). Notably, oauth2 does not have support (see https://go-review.googlesource.com/#/c/oauth2/+/61050/).

LMK your thoughts @andybons, I can look further into this if you think it's important we have support for trybots for playground CLs.

cc @bradfitz

@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Nov 2, 2017

I believe there's an existing open bug to make the coordinator support non-golang.org/x/* dependencies.

@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Dec 14, 2018

Closing this as dup of #24823 as that bug has more detail.

@bradfitz bradfitz closed this Dec 14, 2018
@golang golang locked and limited conversation to collaborators Dec 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.