Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: broken link https://rsc.googlecode.com/hg/testdata/slow.go in plive.go #21951

Closed
mdempsky opened this issue Sep 20, 2017 · 3 comments
Closed

Comments

@mdempsky
Copy link
Member

@mdempsky mdempsky commented Sep 20, 2017

In plive.go, there's this comment:

// the same type t. On https://rsc.googlecode.com/hg/testdata/slow.go, onebitwalktype1
// accounts for 40% of the 6g execution time.

The link no longer works though, and perhaps isn't even true anymore. We should update it appropriately.

/cc @rsc @griesemer

@mdempsky

This comment has been minimized.

Copy link
Member Author

@mdempsky mdempsky commented Sep 20, 2017

@mdempsky

This comment has been minimized.

Copy link
Member Author

@mdempsky mdempsky commented Sep 20, 2017

I just used cmd/compile -cpuprofile on slow.go, and the compiler's only spending 17% of its time in all of plive.go, most of which seems to be going towards livenessprologue and livenesssolve. It doesn't seem like onebitwalktype1 is a bottleneck for slow.go anymore, and it doesn't even show up.

Tangentially, compiling slow.go takes around 3 seconds on my laptop with Go 1.4's 6g, whereas at HEAD it takes around 1.8 seconds.

I think the comment can just be removed.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Sep 20, 2017

Change https://golang.org/cl/65110 mentions this issue: cmd/compile/internal/gc: update comment in plive.go

@gopherbot gopherbot closed this in 93e97ef Sep 20, 2017
@golang golang locked and limited conversation to collaborators Sep 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.