Skip to content

cmd/compile: broken link https://rsc.googlecode.com/hg/testdata/slow.go in plive.go #21951

Closed

Description

@mdempsky

In plive.go, there's this comment:

// the same type t. On https://rsc.googlecode.com/hg/testdata/slow.go, onebitwalktype1
// accounts for 40% of the 6g execution time.

The link no longer works though, and perhaps isn't even true anymore. We should update it appropriately.

/cc @rsc @griesemer

Activity

  1. mdempsky commented on Sep 20, 2017

    @mdempsky
    ContributorAuthor
  2. mdempsky commented on Sep 20, 2017

    @mdempsky
    ContributorAuthor

    I just used cmd/compile -cpuprofile on slow.go, and the compiler's only spending 17% of its time in all of plive.go, most of which seems to be going towards livenessprologue and livenesssolve. It doesn't seem like onebitwalktype1 is a bottleneck for slow.go anymore, and it doesn't even show up.

    Tangentially, compiling slow.go takes around 3 seconds on my laptop with Go 1.4's 6g, whereas at HEAD it takes around 1.8 seconds.

    I think the comment can just be removed.

  3. gopherbot commented on Sep 20, 2017

    @gopherbot
    Contributor

    Change https://golang.org/cl/65110 mentions this issue: cmd/compile/internal/gc: update comment in plive.go

  4. locked and limited conversation to collaborators on Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions