You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
cmd/compile: broken link https://rsc.googlecode.com/hg/testdata/slow.go in plive.go #21951
I just used cmd/compile -cpuprofile on slow.go, and the compiler's only spending 17% of its time in all of plive.go, most of which seems to be going towards livenessprologue and livenesssolve. It doesn't seem like onebitwalktype1 is a bottleneck for slow.go anymore, and it doesn't even show up.
Tangentially, compiling slow.go takes around 3 seconds on my laptop with Go 1.4's 6g, whereas at HEAD it takes around 1.8 seconds.
Activity
mdempsky commentedon Sep 20, 2017
slow.go now resides at https://github.com/rsc/rsc/blob/master/testdata/slow.go
mdempsky commentedon Sep 20, 2017
I just used cmd/compile -cpuprofile on slow.go, and the compiler's only spending 17% of its time in all of plive.go, most of which seems to be going towards livenessprologue and livenesssolve. It doesn't seem like onebitwalktype1 is a bottleneck for slow.go anymore, and it doesn't even show up.
Tangentially, compiling slow.go takes around 3 seconds on my laptop with Go 1.4's 6g, whereas at HEAD it takes around 1.8 seconds.
I think the comment can just be removed.
gopherbot commentedon Sep 20, 2017
Change https://golang.org/cl/65110 mentions this issue:
cmd/compile/internal/gc: update comment in plive.go