Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archive/tar: TestSparseFiles failing on plan9/arm builder #21977

Open
0intro opened this issue Sep 22, 2017 · 3 comments
Open

archive/tar: TestSparseFiles failing on plan9/arm builder #21977

0intro opened this issue Sep 22, 2017 · 3 comments
Assignees
Labels
Milestone

Comments

@0intro
Copy link
Member

@0intro 0intro commented Sep 22, 2017

CL 60871 added TestSparseFiles. This test is failing on the plan9/arm builder.

--- FAIL: TestSparseFiles (117.51s)
    --- FAIL: TestSparseFiles/EmptyFile (0.17s)
    	tar_test.go:844: unexpected ReadFrom error: tar: write too long
    --- FAIL: TestSparseFiles/BigHole (0.25s)
    	tar_test.go:844: unexpected ReadFrom error: tar: write too long
    --- FAIL: TestSparseFiles/DataFront (0.44s)
    	tar_test.go:844: unexpected ReadFrom error: tar: write too long
    --- FAIL: TestSparseFiles/HoleFront (1.43s)
    	tar_test.go:872: sparse files mismatch
    --- FAIL: TestSparseFiles/DataMiddle (0.39s)
    	tar_test.go:844: unexpected ReadFrom error: tar: write too long
    --- FAIL: TestSparseFiles/HoleMiddle (1.41s)
    	tar_test.go:872: sparse files mismatch
    --- FAIL: TestSparseFiles/Multiple (109.91s)
    	tar_test.go:872: sparse files mismatch
FAIL
FAIL	archive/tar	140.157s

See https://build.golang.org/log/6c62187355a860390505342ac82661184645f959

@0intro 0intro added this to the Go1.10 milestone Sep 22, 2017
@0intro 0intro self-assigned this Sep 22, 2017
@0intro
Copy link
Member Author

@0intro 0intro commented Sep 22, 2017

The test is only failing on the plan9/arm builder because this builder use the Fossil file system for /tmp instead of ramfs.

It seems there is an issue with the handling of sparse files in the Fossil file system.

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 22, 2017

Change https://golang.org/cl/65352 mentions this issue: archive/tar: skip TestSparseFiles on Plan 9

Loading

gopherbot pushed a commit that referenced this issue Sep 22, 2017
CL 60871 added TestSparseFiles. This test is succeeding
on Plan 9 when executed on the ramfs file system, but
is failing when executed on the Fossil file system.

This may be due to an issue in the handling of sparse
files in the Fossil file system on Plan 9 that should
be investigated.

Updates #21977.

Change-Id: I177afff519b862a5c548e094203c219504852006
Reviewed-on: https://go-review.googlesource.com/65352
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@dsnet
Copy link
Member

@dsnet dsnet commented Sep 22, 2017

I'll investigate why this is failing on Plan9. On OS without sparse file support, this test should still pass. It does however rely on being able to Seek beyond the EOF and write some data, with the assumption that the data in-between is filled with zeros (and on OS+FS that support it, represented by a sparse hole).

Loading

@dsnet dsnet removed this from the Go1.10 milestone Oct 11, 2017
@dsnet dsnet added this to the Unplanned milestone Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants