Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: ask trybots to submit on pass #22123

Closed
crawshaw opened this issue Oct 3, 2017 · 1 comment

Comments

Projects
None yet
4 participants
@crawshaw
Copy link
Contributor

commented Oct 3, 2017

Right now we +1 trybots on gerrit to run the trybots.

We could have a feature where we +2 trybots and have the bots submit the CL when it passes. A human reviewer would have to have already +2ed the CL.

This is a potential alternative to #12482. It's less invasive, because instead of the reviewer triggering the submission, the author triggers it.

(We have this feature on fuchsia's gerrit and it is very useful.)

@bradfitz

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

Dup of #12482 (from two years prior)

@bradfitz bradfitz closed this Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.