Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: arbitrary code execution during “go get” or “go get -d” [Go 1.9] #22131

Closed
rsc opened this issue Oct 4, 2017 · 5 comments
Closed
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Security
Milestone

Comments

@rsc
Copy link
Contributor

rsc commented Oct 4, 2017

See #22125 for details.

Fixed in Go 1.9.1 by CL 68022 (bc907974a35a).

@rsc rsc added this to the Go1.9.1 milestone Oct 4, 2017
@rsc rsc changed the title placeholder for security issue cmd/go: arbitrary code execution during “go get” or “go get -d” [Go 1.9] Oct 4, 2017
@rsc rsc closed this as completed Oct 4, 2017
@dmitshur
Copy link
Contributor

dmitshur commented Oct 5, 2017

Fixed in Go 1.9.1 by CL 68022 (bc907974a35a).

Can you please clarify what commit that is? I'm not able to find "bc907974a35a".

@ianlancetaylor
Copy link
Contributor

ianlancetaylor commented Oct 5, 2017

@shurcooL Doesn't the CL link work for you? https://golang.org/cl/68022.

@dmitshur
Copy link
Contributor

dmitshur commented Oct 5, 2017

Yes it does, but it says it was merged as a different commit, a39bcec. That's why I am puzzled about what "bc907974a35a" is.

@ianlancetaylor
Copy link
Contributor

ianlancetaylor commented Oct 5, 2017

Ah. Perhaps a typo.

The change was committed three times that I know of, to different branches:

@dmitshur
Copy link
Contributor

dmitshur commented Oct 5, 2017

Ah. Perhaps a typo.

I see. Thank you for clarifying.

@golang golang locked and limited conversation to collaborators Oct 5, 2018
@dmitshur dmitshur added the CherryPickApproved Used during the release process for point releases label Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Security
Projects
None yet
Development

No branches or pull requests

5 participants