cmd/vet: incorrect detection of self-assignment

[klauspost]

What version of Go are you using (go version)?

>go version
go version go1.9.1 windows/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

set GOARCH=amd64
set GOBIN=
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=d:\dev\gopath\
set GORACE=
set GOROOT=C:\Go
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=e:\temp\wintemp\go-build563293679=/tmp/go-build -gno-record-gcc-switches
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config

What did you do?

Save https://play.golang.org/p/d5JNE7rvLc to main.go
Execute go vet main.go

What did you expect to see?

Nothing. The code is not self-assigning.

What did you see instead?

main.go:11: self-assignment of s[rng.Intn(len(s))] to s[rng.Intn(len(s))]
exit status 1

[mvdan]

I'll take a stab at this later.

[gopherbot]

Change https://golang.org/cl/69116 mentions this issue: cmd/vet: skip self-assigns that contain any calls