Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: build.golang.org should link to Gerrit, not GitHub commits #22217

Closed
rsc opened this issue Oct 11, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@rsc
Copy link
Contributor

commented Oct 11, 2017

The left column of build.golang.org has Git commit hashes, and it links to

https://github.com/golang/go/commit/<COMMIT>

But all of us most commonly use Gerrit to view commits. We should probably do the same here. The URL should change to

https://go-review.googlesource.com/q/<COMMIT>

Not sure who, if anyone, is in charge of build.golang.org these days.

/cc @andybons @adams-sarah

@rsc rsc added this to the Unreleased milestone Oct 11, 2017

@gopherbot gopherbot added the Builders label Oct 11, 2017

@adams-sarah

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2017

I am responsible for fixing builder bugs. Features I'm pushing out 'til @bradfitz gets back. Lack of time.
Maybe Andy can take this.

@andybons andybons self-assigned this Oct 11, 2017

@gopherbot

This comment has been minimized.

Copy link

commented Oct 11, 2017

Change https://golang.org/cl/70170 mentions this issue: x/build: link to Gerrit changes instead of GitHub commits

@adams-sarah

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2017

Thanks Andy.

@andybons

This comment has been minimized.

Copy link
Member

commented Oct 13, 2017

This has been deployed to build.golang.org.

There is a bug where going back from the Gerrit change page via this shortcut is broken, but a fix for that was also submitted (https://gerrit-review.googlesource.com/132930) and should be live whenever Gerrit deploys next (week or two?).

@golang golang locked and limited conversation to collaborators Oct 13, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.