Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/compile: regression in TestIntendedInlining on ppc64x, others #22239
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
@mvdan Correct, MIPS64 is not a trybot architecture.
The problem is nextFreeFast really is too expensive to inline on MIPS64, because we don't have an optimized version of Ctz64 on that arch. However, because of #19261, we weren't correctly accounting for how expensive Ctz64 is, so we were inlining nextFreeFast anyway.
Since inlining budget calculation is fixed in CL 70151 runtime.nextFreeFast is no longer inlineable on MIPS64x because it does not support Ctz64 as intrinsic. Skip the test. Updates #22239. Change-Id: Id00d55628ddb4b48d27aebfa10377a896765d569 Reviewed-on: https://go-review.googlesource.com/72271 Run-TryBot: Cherry Zhang <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Matthew Dempsky <firstname.lastname@example.org>
Mark nextFreeFast as not inline, as it is too expensive to inline on riscv64. Also remove riscv64 from non-atomic inline architectures, as we now have atomic intrisics. Updates #22239 Change-Id: I6e0e72c1192070e39f065bee486f48df4cc74b35 Reviewed-on: https://go-review.googlesource.com/c/go/+/227808 Reviewed-by: Cherry Zhang <email@example.com> Run-TryBot: Cherry Zhang <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com>