Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
syscall: timeout parameter to Select is treated as Timespec instead of Timeval on linux/arm64 #22246
What version of Go are you using (
…s64x} Follow CL 70590 which did the same for syscall. unix.Select uses SYS_PSELECT6 on arm64 and mipx64x, however this syscall expects its 5th argument to be of type Timespec (with seconds and nanoseconds) instead of type Timeval (with seconds and microseconds) This leads to the timeout being too short by a factor of 1000. This CL fixes this by adjusting the timeout argument accordingly, similarly to how glibc does it for architectures where neither SYS_SELECT nor SYS__NEWSELECT are available. It also makes Pselect generaly available on linux. Updates golang/go#22246 Change-Id: I69f8821a40c59ee469b8a986d784a4db8727ee9a Reviewed-on: https://go-review.googlesource.com/70610 Run-TryBot: Ian Lance Taylor <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org> Reviewed-by: Ian Lance Taylor <email@example.com>
Test for correct timeout behavior of Select and Pselect Updates golang/go#22246 Change-Id: I86d1804c6ddf5072e93f3ef4f359198e732fae94 Reviewed-on: https://go-review.googlesource.com/84955 Run-TryBot: Tobias Klauser <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Brad Fitzpatrick <firstname.lastname@example.org>